Code

Add typing to otfautohint#1719

Code

Open

simoncozens wants to merge 42 commits intoadobe-type-tools:developadobe-type-tools/afdko:developfrom simoncozens:fixups-and-typessimoncozens/afdko:fixups-and-typesCopy head branch name to clipboard

+715-435

Commits

Commits on Oct 18, 2023

• Fix typo

  simoncozens

  committed
  b2de9cf

  Copy full SHA for b2de9cf

• Wait, this whole method is dead

  simoncozens

  committed
  1448a92

  Copy full SHA for 1448a92

• Typo

  simoncozens

  committed
  fb4e2c5

  Copy full SHA for fb4e2c5

• Assertions to avoid unbound/None access

  simoncozens

  committed
  fc4a454

  Copy full SHA for fc4a454

• ABC annotations only make sense if we're an ABC

  simoncozens

  committed
  57fbdce

  Copy full SHA for 57fbdce

• More assertions to calm type checkers

  simoncozens

  committed
  b7e51f6

  Copy full SHA for b7e51f6

• Dead code?

  simoncozens

  committed
  10700c2

  Copy full SHA for 10700c2

Commits on Oct 19, 2023

• Hopefully uncontroversial typings

  simoncozens

  committed
  bf643ad

  Copy full SHA for bf643ad

• Import the types

  simoncozens

  committed
  d078bfd

  Copy full SHA for d078bfd

• Make point into an ordinary class, not a tuple, because reasons

  simoncozens

  committed
  b7d0ece

  Copy full SHA for b7d0ece

• Typing requires types.

  simoncozens

  committed
  1e37190

  Copy full SHA for 1e37190

• Uncontroversial typings

  simoncozens

  committed
  b729bb1

  Copy full SHA for b729bb1

• Some more typings

  simoncozens

  committed
  49f35c2

  Copy full SHA for 49f35c2

• Really void functions

  simoncozens

  committed
  f8ca0b5

  Copy full SHA for f8ca0b5

• Better typings

  simoncozens

  committed
  c46b555

  Copy full SHA for c46b555

• Mainly assertions

  simoncozens

  committed
  dac1ad0

  Copy full SHA for dac1ad0

• More type hints

  simoncozens

  committed
  48551a5

  Copy full SHA for 48551a5

• Move number upstairs, others

  simoncozens

  committed
  2c24afa

  Copy full SHA for 2c24afa

• Complex numbers would be a mistake here

  simoncozens

  committed
  cb04597

  Copy full SHA for cb04597

• More type hinting

  simoncozens

  committed
  e338e32

  Copy full SHA for e338e32

• This was a true optional

  simoncozens

  committed
  40badd5

  Copy full SHA for 40badd5

• More fixups

  simoncozens

  committed
  db2a6dc

  Copy full SHA for db2a6dc

• Oops, they reused a variable

  simoncozens

  committed
  c8687bc

  Copy full SHA for c8687bc

• Fix assertion

  simoncozens

  committed
  916aa85

  Copy full SHA for 916aa85

• Make mypy happy without check-untyped-defs

  simoncozens

  committed
  7d3d512

  Copy full SHA for 7d3d512

• As close to done as I'm getting

  simoncozens

  committed
  84fe6b0

  Copy full SHA for 84fe6b0

• Fix failing test

  simoncozens

  committed
  6ac132e

  Copy full SHA for 6ac132e

• Use typing_extensions to support <3.11

  simoncozens

  committed
  ef05a40

  Copy full SHA for ef05a40

• Restore formatting

  simoncozens

  committed
  5e5a0e3

  Copy full SHA for 5e5a0e3

Commits on Oct 20, 2023

• Ignore mypy error

  simoncozens

  committed
  60f2ea3

  Copy full SHA for 60f2ea3

• Use lo/hi, not tuple

  simoncozens

  committed
  f4128b9

  Copy full SHA for f4128b9

• pathElement is optional in hintSegment

  simoncozens

  committed
  f11236d

  Copy full SHA for f11236d

• Good catch

  simoncozens

  committed
  68a6f63

  Copy full SHA for 68a6f63

• Check all methods

  simoncozens

  committed
  f4c5c6b

  Copy full SHA for f4c5c6b

• Add mypy to requirements-dev

  simoncozens

  committed
  e8375c9

  Copy full SHA for e8375c9

• Run mypy on build

  simoncozens

  committed
  4c286d0

  Copy full SHA for 4c286d0

• Restore code style

  simoncozens

  committed
  859f98d

  Copy full SHA for 859f98d

• Slacken off the weakref type to make 3.8 happier

  simoncozens

  committed
  2e7f3a2

  Copy full SHA for 2e7f3a2

• Remove dead import

  simoncozens

  committed
  9046243

  Copy full SHA for 9046243

• pytype does not support Self yet

  simoncozens

  committed
  40522b1

  Copy full SHA for 40522b1

• Explain Protocol class

  simoncozens

  committed
  d034b45

  Copy full SHA for d034b45

• List can be subscripted, list can't

  simoncozens

  committed
  0945357

  Copy full SHA for 0945357