Remove types
setting from pull_request
#1664
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
types
setting frompull_request
section of workflow files.This setting was originally added to prevent the CI from triggering twice (on
push
and onpull-request
) with each commit to a branch with an opened PR. The current workflow configuration works fine for developers that have privileges to push branches to the repo, but it has the adverse side-effect of getting the CI stuck on PRs from forks, if the external developer makes commits to their branches after the PR has been opened.I've made this same change on another project and I'm only seeing duplicate CI runs on one kind of event: when the PR is opened. After that, all commits to the branch only trigger
pull_request
CI runs (and notpush
CI runs).