Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(etcd-backup): podAnnotations #1371

Merged
merged 6 commits into from
Jan 30, 2025
Merged

feat(etcd-backup): podAnnotations #1371

merged 6 commits into from
Jan 30, 2025

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented Jan 30, 2025 •
edited
Loading

Description

Adds the ability of setting annotations on pod level inside the cronjob

Issues

adding annotations on the running cronjob is not possible due to the chart not supporting it

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@eyenx eyenx requested a review from a team as a code owner January 30, 2025 11:43
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2025
@eyenx eyenx marked this pull request as draft January 30, 2025 11:43
hairmare
hairmare previously approved these changes Jan 30, 2025
View reviewed changes
@eyenx eyenx marked this pull request as ready for review January 30, 2025 13:05
@eyenx
Copy link
Member Author

eyenx commented Jan 30, 2025

CI needs fixi fixi

@eyenx
Copy link
Member Author

eyenx commented Jan 30, 2025

And also linter fucky wacky

@eyenx eyenx requested a review from hairmare January 30, 2025 13:30
@cfi2017 cfi2017 changed the title feat(etc-dbackup): podAnnotations feat(etcd-backup): podAnnotations Jan 30, 2025
@eyenx
fix(snapshots): revert
946d84a 
Signed-off-by: Toni Tauro <[email protected]>
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2025
@eyenx eyenx requested a review from cfi2017 January 30, 2025 15:12
cfi2017
cfi2017 previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@cfi2017 cfi2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyenx
fix(ketcbackup): README
9053600 
Signed-off-by: Toni Tauro <[email protected]>
cfi2017
cfi2017 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@cfi2017 cfi2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyenx eyenx enabled auto-merge (squash) January 30, 2025 15:20
@eyenx eyenx merged commit 89089df into main Jan 30, 2025
3 checks passed
@eyenx eyenx deleted the feat/etcd-backup/podAnnotations branch January 30, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfi2017 cfi2017 cfi2017 approved these changes

@inisitijitty inisitijitty Awaiting requested review from inisitijitty inisitijitty is a code owner automatically assigned from adfinis/helm-charts

@hairmare hairmare Awaiting requested review from hairmare

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyenx @hairmare @cfi2017