Base class clenup #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratbilir
force-pushed
the
feature/baseless-structure
branch
from
b1dc8fa to
c8c593f
Compare
… of "composition over inheritance".
muratbilir
force-pushed
the
feature/baseless-structure
branch
from
c8c593f to
7b2340b
Compare
…n favor of "composition over inheritance".
… of "composition over inheritance".
muratbilir
force-pushed
the
feature/baseless-structure
branch
from
40b1176 to
fa80964
Compare
hcknl
reviewed
Jul 25, 2024
hcknl
reviewed
Jul 25, 2024
| } | ||
|
|
||
| override fun getValue(thisRef: Fragment, property: KProperty<*>): T { | ||
| val binding = binding |
hcknl
reviewed
Jul 25, 2024
| } | ||
|
|
||
| is NavigationCommand.ToDeepLink -> { | ||
| (activity as? MainActivity) |
There was a problem hiding this comment.
not likely for single activity apps but someone can create another activity and this interface will be dependent on MainActivity, maybe we should consider an interface like "NavigatableActivity" or something else.
hcknl
reviewed
Jul 25, 2024
| model.message?.let { setMessage(it) } | ||
| model.messageInt?.let { setMessage(it) } |
hcknl
reviewed
Jul 25, 2024
app/src/main/kotlin/com/adesso/movee/internal/util/api/NetworkCallAdapter.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All base classes (activity, fragment, viewModel) are removed in favor of "composition over inheritance".