Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Dependencies and Improve Compatibility for Build Process #593

Merged
merged 7 commits into from
Jan 25, 2025

Conversation

amerryma
Copy link
Contributor

@amerryma amerryma commented Oct 11, 2024

Description:

This PR includes several housekeeping updates to ensure the build process continues to function smoothly after updates from Renovate and GitHub.

Key Updates:

  • chore(deps): Updated chokidar file watching to version 4

    • Since chokidar was updated to version 4, which introduced changes to function signatures, I've adjusted the code to align with the new signature and configuration. There is no functional difference expected in behavior.
  • chore(deps): Dropped support for Node.js version 16

    • Node.js 16 is no longer supported, paving the way for future updates that require newer versions of Node.js.
  • chore(deps): Updated Piscina to use ESM imports

    • Migrated to ESM imports as required by the latest versions of Piscina. Additionally, enabled resolving JSON modules as this is now used by Piscina.
  • chore(prettier): Ignored runtime/lib folder

    • Added the runtime lib folder to the .prettierignore file to avoid unnecessary formatting checks in this directory.
  • chore(compose): Updated Docker Compose syntax

    • Migrated to the new Docker Compose V2 syntax following the GitHub-hosted runner image deprecation notice. See GitHub Changelog for details.

This PR does not introduce any breaking changes but is necessary to keep the project up-to-date with the latest versions and best practices.

Upgrading to version 4 of chokidar changed some the function signatures.
Code has been updated to use new signature and configuration. No
functional difference should be noticed.
Also need to enable resolving json modules as Piscina does this in their
latest versions.
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pgtyped ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 6:23pm

@amerryma
Copy link
Contributor Author

@adelsz Are you currently accepting external PRs?

@SebastienGllmt SebastienGllmt mentioned this pull request Nov 22, 2024
Copy link
Owner

@adelsz adelsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amerryma
Merging as is. New chokidar types are making TS unhappy, but I will fix it in main branch.

@adelsz adelsz merged commit 01fbaf0 into adelsz:master Jan 25, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants