Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Treat _isLocked as a lockable attribute #231

Merged
merged 1 commit into from
Oct 9, 2024
Merged

New: Treat _isLocked as a lockable attribute #231

merged 1 commit into from
Oct 9, 2024

Conversation

oliverfoster
Copy link
Member

part of adaptlearning/adapt-contrib-core#584

New

  • Treat _isLocked as a lockable attribute, allowing plugins or core to force _isLocked: true

requires adaptlearning/adapt-contrib-core#585

@oliverfoster oliverfoster self-assigned this Sep 25, 2024
@oliverfoster oliverfoster mentioned this pull request Sep 25, 2024
Merged
swashbuck
swashbuck approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 20067c6 into master Oct 9, 2024
1 check passed
@swashbuck swashbuck deleted the issue/584-islocked branch October 9, 2024 17:20
github-actions bot pushed a commit that referenced this pull request Oct 9, 2024
@semantic-release-bot
Chore(release): 7.5.0 [skip ci]
fc51663 
# [7.5.0](v7.4.2...v7.5.0) (2024-10-09)

### New

* Treat _isLocked as a lockable attribute (fixes #231) ([20067c6](20067c6)), closes [#231](#231)
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@joe-replin joe-replin joe-replin approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @swashbuck @joe-replin @cahirodoherty-learningpool