return early from setValue if there's an error (so that it won't trig…

…ger a commitOnAnyChange commit)
adaptlearning · Oct 16, 2020 · 617572a · 617572a
1 parent 9804c8b
commit 617572a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/js/scorm/wrapper.js b/js/scorm/wrapper.js
@@ -427,12 +427,11 @@ define([
             errorInfo: this.scorm.debug.getInfo(errorCode),
             diagnosticInfo: this.scorm.debug.getDiagnosticInfo(errorCode)
           }));
-        } else {
-          this.logger.warn(`ScormWrapper::setValue: LMS reported that the 'set' call failed but then said there was no error!`);
+          return success;
         }
+        this.logger.warn(`ScormWrapper::setValue: LMS reported that the 'set' call failed but then said there was no error!`);
       }
 
-
       if (this.commitOnAnyChange) this.debouncedCommit();
 
       return success;