Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default seek, event.target, import await, forward scrubbing, fullscreen inview #311

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jan 6, 2025

requires adaptlearning/adapt-contrib-core#612
fixes #304

Fix

  • import() returns a promise
  • android triggers timeupdate before seeking which prevents the seek blocking behaviour
  • defaultSeekBackwardInterval and defaultSeekForwardInterval need to be converted to functions from strings at runtime
  • onMediaElementTimeUpdate and onMediaElementSeeking do not have event.target on windows chrome use event.currentTarget instead
  • inview + fullscreen locking

@oliverfoster oliverfoster changed the title DefaultSeek, event.target, import await, prevent forward scrubbing android Fix: Default seek, event.target, import await, forward scrubbing, fullscreen inview Jan 7, 2025
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit b6a124b into issue/298 Jan 13, 2025
@oliverfoster oliverfoster deleted the issue/298b branch January 13, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Recently Released
Development

Successfully merging this pull request may close these issues.

2 participants