Chore: e2e tests on graphic component (Issue/95)

[lemmyadams]

Addresses #95

[cahirodoherty-learningpool]

Hi guys, just to clear up a little confusion on this - I think our option here may end up being cy.wait(X) as you suggest, but I am hesitant to get into the pattern of throwing waits in too often as it can bloat the running time of the Cypress tests as a whole.
My nudge towards exploring promises/some sort of async manipulation was to avoid that in the cases where possible.

For example, here our wait is needed because we are waiting on page load. But it is preferable to react to a known outcome of page load (some event trigger for example) rather than an arbitrary amount of time.

Now I'm not sure of exactly the correct thing to listen out for, but thought it was worth exploring

[oliverfoster]

Hi guys, just to clear up a little confusion on this - I think our option here may end up being cy.wait(X) as you suggest, but I am hesitant to get into the pattern of throwing waits in too often as it can bloat the running time of the Cypress tests as a whole. My nudge towards exploring promises/some sort of async manipulation was to avoid that in the cases where possible.

For example, here our wait is needed because we are waiting on page load. But it is preferable to react to a known outcome of page load (some event trigger for example) rather than an arbitrary amount of time.

Now I'm not sure of exactly the correct thing to listen out for, but thought it was worth exploring

Some interesting strategies here https://stackoverflow.com/questions/64421563/cypress-wait-for-unpredictable-component-to-render-from-an-exclusive-set

[cahirodoherty-learningpool]

👀

[joe-allen-89]

👍

[github-actions]

🎉 This PR is included in version 6.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀