Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Perform HTMLDialogElement.close on drawer before animating closed (fixes #628) #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 19, 2025

Additional fixes to pr #601

fixes #628

When plp navigates to a different page it causes both the drawer to close and the pip notify to open. The drawer dialog should be closed before the notify is open such that the drawer close doesn't accidentally close the new notify at

_removeLastPopupLayer() {
// the body layer is the first element and must always exist
if (this._floorStack.length <= 1) {
return;
}
const $popupElement = this._floorStack.pop();
if ($popupElement.is('dialog')) {
$popupElement[0].close();
return this._focusStack.pop();

Reverting to previous behaviour in v6.60.2

hideDrawer($toElement) {
if (!this._isVisible) return;
this._useMenuPosition = false;
const direction = {};
a11y.popupClosed($toElement);

Fix

  • Perform HTMLDialogElement.close on drawer before animating closed

@oliverfoster oliverfoster self-assigned this Feb 19, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Reviewing
Development

Successfully merging this pull request may close these issues.

Notify display issue when drawer is closed
3 participants