Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: restricts attempts to 1 (fixes #53) #109

Closed
wants to merge 1 commit into from
Closed

Update: restricts attempts to 1 (fixes #53) #109

wants to merge 1 commit into from

Conversation

henrietta-k
Copy link

//: # Original issue: #53

Update

  • Added "maximum" and "minimum" attributes to restrict the number of "_attempts" to 1 (as described in the README)
  • Deleted the property "remainingAttemptsText" because it is not possible for multiple attempts to be left
  • Deleted the property "remainingAttemptText" because there is no "final attempt" since only 1 attempt is allowed

@oliverfoster
Copy link
Member

Why not just delete the _attempts field from the schema?

There is a second schema that needs updating also https://github.com/adaptlearning/adapt-contrib-confidenceSlider/blob/master/properties.schema

@henrietta-k henrietta-k closed this by deleting the head repository Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
adapt_framework: The TODO Board
Status: Awaiting Response
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrietta-k @oliverfoster