Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,17 @@ jobs:
name: misspell
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: misspell
uses: reviewdog/[email protected]
with:
github_token: ${{ secrets.github_token }}
locale: "US"
level: info

pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: pre-commit/[email protected]
32 changes: 32 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
hooks:
# Git style
- id: check-added-large-files
- id: check-merge-conflict
- id: check-vcs-permalinks
- id: forbid-new-submodules
- id: no-commit-to-branch

# Common errors
- id: end-of-file-fixer
- id: trailing-whitespace
- id: check-yaml
args: [--allow-multiple-documents]
- id: check-merge-conflict
- id: check-executables-have-shebangs

# Cross platform
- id: check-case-conflict
- id: mixed-line-ending
args: [--fix=lf]

# Security
- id: detect-aws-credentials
args: ['--allow-missing-credentials']
- id: detect-private-key

# - id: debug-statements
# - id: double-quote-string-fixer
# - id: name-tests-test
1 change: 0 additions & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -435,4 +435,3 @@ the avoidance of doubt, this paragraph does not form part of the
public licenses.

Creative Commons may be contacted at creativecommons.org.

1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,3 @@ aws cloudformation create-stack \
ParameterKey=FullDomainName,ParameterValue=<<WWW.EXAMPLE.COM>> \
ParameterKey=AcmCertificateArn,ParameterValue=<<ACM ARN STRING>>
```

1 change: 0 additions & 1 deletion config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,3 @@
# turn on article support
ogp.blog = true
end

2 changes: 1 addition & 1 deletion data/faq.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
questions:
questions:

- q: What kind of van was it?
a: >-
Expand Down
1 change: 0 additions & 1 deletion helpers/dana_lol_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,3 @@ def google_analytics
end

end

1 change: 0 additions & 1 deletion source/.well-known/keybase.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,3 @@ appending to this document.
View my publicly-auditable identity here: https://keybase.io/adanalife

==================================================================

1 change: 0 additions & 1 deletion source/2017-09-23-playing-with-style.html.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,3 @@ end
<% iframe_wrapper do %>
<iframe width="693" height="734" src="https://www.youtube.com/embed/rjKyHNtJKNk?ecver=1" frameborder="0" allowfullscreen></iframe>
<% end %>

1 change: 0 additions & 1 deletion source/2017-10-01-how-this-site-works.html.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,3 @@ For example, <%= link_to "the source code for this article is available for you
<br>

In <%= link_to('part 2', '/2017/10/12/how-this-site-works-p-2/') %>, I talk about the visual design of the site and how I did it.

Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,3 @@ Even if you don't get licensed:
* Perhaps most importantly: **you are allowed to talk in an emergency!**

With all of this in mind, it seems like a good idea for SF residents to have a two-way radio in their home with their emergency supplies. In [the next article](/2017/10/26/setting-up-a-handheld-radio-for-emergencies/) I walk you through buying and setting up your radio.

1 change: 0 additions & 1 deletion source/2017-10-12-how-this-site-works-p-2.html.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,3 @@ I can't thank them enough, they've made my job so much easier.

What appeals to me about about this design is that someone has provided me with a set of opinionated "best practices" for design.
I'm sure I'm going to break the rules, but at least now I _have_ rules, which is an issue I have with web design in general.

Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,3 @@ You'll barely notice almost 8 minutes have gone by.
<% iframe_wrapper do %>
<iframe width="560" height="349" src="https://www.youtube.com/embed/ersAaDvQ_DM?ecver=1" frameborder="0" allowfullscreen></iframe>
<% end %>

3 changes: 1 addition & 2 deletions source/2017-10-25-i-got-a-van.html.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ It's a *1992 Dodge Roadtrek 190 Versatile*.
<%= figure "#{current_article.url}the-van.png", 'My van' %>

Out of all of the vans in the Bay Area, why did I pick this one?
Well, a ton of thought went into the decision, but I can provide a summary.
Well, a ton of thought went into the decision, but I can provide a summary.

Originally I wanted a [Westfalia](https://en.wikipedia.org/wiki/Volkswagen_Westfalia_Camper), because I find their boxy aesthetic adorable.
I rented one for two weeks, but decided that I wanted something newer, something more reliable.
Expand All @@ -45,4 +45,3 @@ I scoured Craigslist posts for months looking for vans that met as many of these
I'm happy to say that this Roadtrek meets almost all of them, and more!<%= mn "The only criteria I couldn't meet? It's not a 4WD van, but all of those were way out of my price range." %>
I can stand in it, it has a full kitchen, it has a toilet if I want it, and so much more.
I'm beyond excited, and I can't wait to share more adventures with you!

Loading
Loading