-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move bundle config to JSON format #126
Conversation
Looking at the failures... they initially passed on my end. But I can reproduce the failure now. |
Comment 4 on the description describes how I fixed the tests. Not sure its the best way. But worked. |
We should rev the major version number if we merge this. It might be a breaking change for anyone using the circup.py file name directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense but didn't test.
As an improvement, consider using https://pypi.org/project/appdirs/ so that you can look for the config json file first in the user's configuration directory and then to the default list shipped in the package. |
@jepler Good idea... Do you see that overriding the default or supplementing the default? |
My idea for supporting 3rd party bundles was to have new commands (bundle-add, bundle-remove, bundle-info) that manage a separate list, while the default bundles would always remain. But the ability to override the default list, to maybe disable built-in ones, or change the order (to have a 3rd party neopixel implementation override the adafruit one for example) seems a possibly useful idea. Maybe adding also a bundle-reset command to reset the list to the default one. |
Probably supplementing the regular list.. (figuring it out silent block this PR from being merged) |
We could merge this as-is and then work out the design for these other ideas in a new issue. |
I opened an issue on the 3rd Party Bundle Support - 127. So we can move this PR along. |
Fixes #125
bundle_config.json
which is added to the setup.py data_files. It is assumed to be insys.prefix
.test_bundle_config.json
test_bundle_name
to use thetest_bundle_config.json
value