Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Update GPIO pin assignments for BTN5 and BUTTON in oxocard_connect board #9932

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

supcik
Copy link

@supcik supcik commented Jan 3, 2025

Here is a PR to fix an incorrect PIN assignment for the Oxocard Connect.

Note that the pre-commit hook also changed the .pot file, but this is not part of my change.

@supcik supcik changed the title Update GPIO pin assignments for BTN5 and BUTTON in oxocard_connect board Fix : Update GPIO pin assignments for BTN5 and BUTTON in oxocard_connect board Jan 3, 2025
@tannewt
Copy link
Member

tannewt commented Jan 6, 2025

How does pre-commit fail if you don't add that file to the commit. It should be updated separately. Thanks!

@supcik
Copy link
Author

supcik commented Jan 6, 2025

Thank you for your reply. I guess that I ran pre-commit run --all-files. I will fix my PR.

@supcik supcik force-pushed the fix-oxocard-connect-pin-assignments branch from 59175d9 to 2d4c010 Compare January 6, 2025 23:33
@supcik supcik force-pushed the fix-oxocard-connect-pin-assignments branch from 2d4c010 to e9fa84b Compare January 6, 2025 23:35
@supcik
Copy link
Author

supcik commented Jan 6, 2025

I fixed my PR with just the file that I changed.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 571589d into adafruit:main Jan 7, 2025
15 checks passed
@supcik
Copy link
Author

supcik commented Jan 7, 2025

Thank you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants