Fix ratelimit timezone #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) The "core rate limit reset" time is in UTC, while github actions may be running in another timezone, such as PST. The below example was run in my local timezone, CST: ```python >>> import os, datetime >>> import github as pygithub >>> GH_INTERFACE = pygithub.Github(os.environ.get("ADABOT_GITHUB_ACCESS_TOKEN")) >>> GH_INTERFACE.get_rate_limit().core.reset - datetime.datetime.now() datetime.timedelta(seconds=24750, microseconds=356986) >>> GH_INTERFACE.get_rate_limit().core.reset - datetime.datetime.utcnow() datetime.timedelta(seconds=3147, microseconds=87271) ``` Use utcnow() instead of now() so that the sleep is for the correct duration. (utcnow is deprecated, but the correct alternative, `now(tz=datetime.timezone.utc)` does not work: `GH_INTERFACE.get_rate_limit().core.reset` is a naive timestamp and can't be compared with a tz-aware object)
|
we're on an old pygithub. the time zone problem of the rate limit is fixed in 2.0.0 (current is 2.1.x) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that sites that use pygithub to wait for the rate limit reset time were performing incorrect arithmetic between an UTC timestamp and a local timestamp. This led to the sleep taking hours more time than they should.
Some requests are made via pygithub and some via our own API + requests; the requests code was right while the API code was wrong. This made the cron task fail sometimes, depending whether the first rate-limited result was via API or via raw requests.