Added support for color depth #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed a whitespace issue and reverted to the included swap defines. At least with Arduino 1.6.9, the global "swap" define doesn't seem to exist. https://github.com/dhiltonp/Adafruit_SHARP_Memory_Display/tree/radjaz-changes |
|
The definition is not correct in the header. I see: define SHARPMEM_LCDDEPTH (1) and should be: define SHARPMEM_LCDDEPTH (3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for color depth because sharp sells a memory LCD with a color depth of 3. I have tested this library on that LCD with a feather m0 and it works. The part number for this LCD is LS013B7DH06 and is compatible with existing sharp memory LCD breakout boards.