Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse POINT(...) as GeoPoint in a SPARQL query #1731

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jan 24, 2025

Specifying an explicit POINT(...) in a SPARQL query could lead to a segmentation fault because it wasn't actually parsed as a GeoPoint. This is now fixed.

Signed-off-by: Johannes Kalmbach <[email protected]>
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (ff47922) to head (9632613).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1731   +/-   ##
=======================================
  Coverage   89.92%   89.93%           
=======================================
  Files         393      393           
  Lines       37614    37599   -15     
  Branches     4231     4231           
=======================================
- Hits        33823    33813   -10     
+ Misses       2494     2483   -11     
- Partials     1297     1303    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Johannes Kalmbach <[email protected]>
@sparql-conformance
Copy link

Copy link

sonarqubecloud bot commented Jan 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hannahbast hannahbast marked this pull request as ready for review February 4, 2025 03:39
@hannahbast hannahbast changed the title Fix a small but dramatic bug in TripleComponent.cpp Properly parse explicit GeoPoints in a query Feb 4, 2025
@hannahbast hannahbast changed the title Properly parse explicit GeoPoints in a query Parse POINT(...) as GeoPoint in a SPARQL query Feb 4, 2025
@hannahbast hannahbast merged commit db6825c into ad-freiburg:master Feb 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants