Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an out-of-bounds read in the OPTIONAL JOIN implementation #1710

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jan 15, 2025

No description provided.

@sparql-conformance
Copy link

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (acb6633) to head (8813fba).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1710   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         389      389           
  Lines       37308    37311    +3     
  Branches     4204     4205    +1     
=======================================
+ Hits        33527    33531    +4     
+ Misses       2485     2481    -4     
- Partials     1296     1299    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@hannahbast hannahbast changed the title Fixed an out-of-bounds read in the OPTIONAL JOIN implementation. Fixed an out-of-bounds read in the OPTIONAL JOIN implementation Jan 23, 2025
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lor for the fix!

@hannahbast hannahbast changed the title Fixed an out-of-bounds read in the OPTIONAL JOIN implementation Fix an out-of-bounds read in the OPTIONAL JOIN implementation Jan 23, 2025
@hannahbast hannahbast merged commit 6f6e0c4 into ad-freiburg:master Jan 23, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants