Add option --parser-buffer-size for IndexBuilderMain
#1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 3, 2025 20:34
So far, the buffer size of the parser was hard-coded in `src/index/ConstantsIndexBuilding.h` to `10 MiB`. This was too little for datasets like OSM, which have some very large triples (due to WKT literals of complex geometries). There is now an option `--parser-buffer-size` with which the default buffer size can be overridden.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
- Coverage 89.86% 89.86% -0.01%
==========================================
Files 389 389
Lines 37287 37307 +20
Branches 4204 4204
==========================================
+ Hits 33509 33526 +17
- Misses 2478 2483 +5
+ Partials 1300 1298 -2 ☔ View full report in Codecov by Sentry. |
Conformance check passed ✅No test result changes. |
|
joka921
approved these changes
Jan 8, 2025
hannahbast
added a commit
to ad-freiburg/qlever-control
that referenced
this pull request
Feb 12, 2025
…lever index` command (#132) So far, the `ulimit` was set to `1048576` when the size of the input files is larger than `10 GB`, which is a simplisitic and rough heuristic. In particular, this does not work when the RDF data is produced from the input file and the latter is relatively small compared to the former. Or when the OS allows increasing the `ulimit` but not that much. Now the `ulimit` can also be set explicitly via the option `--ulimit` of the `qlever index` command, or via the variable `ULIMIT` in the `[index]` section of the Qleverfile. Further, ad-freiburg/qlever#1698 introduced an option `--parser-buffer-size` to `IndexBuilderMain`, see there for the effect. This can now also be set explicitly via the option `--parser-buffer-size` of the `qlever index` command, or via the variable `PARSER_BUFFER_SIZE` in the `[index]` Qleverfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the buffer size of the parser was hard-coded in
src/index/ConstantsIndexBuilding.hto10 MiB. This was too little for datasets like OSM, which have some very large triples (due to WKT literals of complex geometries). There is now an option--parser-buffer-sizewith which the default buffer size can be overridden.While at it, externalize all IRIs and literals (except for the Qlever-internal ones) by default. It has been the default in all our Qleverfiles for quite some time now.