-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return metadata on executed Update #1675
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1675 +/- ##
==========================================
- Coverage 89.90% 89.89% -0.01%
==========================================
Files 393 393
Lines 37479 37565 +86
Branches 4221 4222 +1
==========================================
+ Hits 33694 33770 +76
- Misses 2482 2494 +12
+ Partials 1303 1301 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice, I only have minor suggestions.
We'll have to try this out to check the format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks very clean now, only some miinor suggestions remain.
And @hannahbast could try it out to see if the response fits her expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! I have some minor suggestions + 1.5 questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very great now, did @hannahbast sign off on the exact format in the meantime?
The only thing that remains is fixing the test failure (you changed a error message text, which is asserted).
Yes we discussed it yesterday evening and Hannah approved. I didn't get to adjusting the tests between the changes in the meeting and now, but will do that in the next 3 hours. |
Conformance check passed ✅No test result changes. |
|
SPARQL Update requests sent via HTTP are now answered with a JSON object that contains useful metadata about the request, for example the number of changed triples and timing statistics.