Skip to content

Commit

Permalink
Fix the namespace.
Browse files Browse the repository at this point in the history
Signed-off-by: Johannes Kalmbach <[email protected]>
  • Loading branch information
joka921 committed Feb 10, 2025
1 parent 5bea2f7 commit 87eabd8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 4 additions & 4 deletions src/engine/AddCombinedRowToTable.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@

namespace ad_utility {

namespace {
namespace detail::concepts {
template <typename T>
CPP_requires(HasAsStaticView,
requires(T& table)(table.template asStaticView<0>()));

template <typename T>
CPP_requires(HasGetLocalVocab, requires(T& table)(table.getLocalVocab()));
} // namespace
} // namespace detail::concepts

// This class handles the efficient writing of the results of a JOIN operation
// to a column-based `IdTable`. The underlying assumption is that in both inputs
Expand Down Expand Up @@ -141,7 +141,7 @@ class AddCombinedRowToIdTable {
// `IdTableView<0>`. Identity for `IdTableView<0>`.
template <typename T>
static IdTableView<0> toView(const T& table) {
if constexpr (CPP_requires_ref(HasAsStaticView, T)) {
if constexpr (CPP_requires_ref(detail::concepts::HasAsStaticView, T)) {
return table.template asStaticView<0>();
} else {
return table;
Expand All @@ -153,7 +153,7 @@ class AddCombinedRowToIdTable {
template <typename T>
void mergeVocab(const T& table, const LocalVocab*& currentVocab) {
AD_CORRECTNESS_CHECK(currentVocab == nullptr);
if constexpr (CPP_requires_ref(HasGetLocalVocab, T)) {
if constexpr (CPP_requires_ref(detail::concepts::HasGetLocalVocab, T)) {
currentVocab = &table.getLocalVocab();
mergedVocab_.mergeWith(std::span{&table.getLocalVocab(), 1});
}
Expand Down
2 changes: 0 additions & 2 deletions test/util/IdTableHelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
#include "./IdTestHelpers.h"
#include "engine/CallFixedSize.h"
#include "engine/Engine.h"
#include "engine/Join.h"
#include "engine/OptionalJoin.h"
#include "engine/QueryExecutionTree.h"
#include "engine/idTable/IdTable.h"
#include "global/ValueId.h"
Expand Down

0 comments on commit 87eabd8

Please sign in to comment.