Properly move before returning

ad-freiburg · Feb 10, 2025 · 5d0d58d · 5d0d58d
1 parent 019e7b0
commit 5d0d58d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/engine/QueryPlanner.cpp b/src/engine/QueryPlanner.cpp
@@ -1937,15 +1937,15 @@ std::vector<QueryPlanner::SubtreePlan> QueryPlanner::createJoinCandidates(
   if (b.type == SubtreePlan::MINUS) {
     SubtreePlan plan = makeSubtreePlan<Minus>(_qec, a._qet, b._qet);
     mergeSubtreePlanIds(plan, a, b);
-    return {plan};
+    return {std::move(plan)};
   }
 
   // OPTIONAL JOINS are not symmetric!
   if (b.type == SubtreePlan::OPTIONAL) {
     // Join the two optional columns using an optional join
     SubtreePlan plan = makeSubtreePlan<OptionalJoin>(_qec, a._qet, b._qet);
     mergeSubtreePlanIds(plan, a, b);
-    return {plan};
+    return {std::move(plan)};
   }
 
   if (auto opt = createJoinWithPathSearch(a, b, jcs)) {
@@ -1959,7 +1959,7 @@ std::vector<QueryPlanner::SubtreePlan> QueryPlanner::createJoinCandidates(
     try {
       SubtreePlan plan = makeSubtreePlan<MultiColumnJoin>(_qec, a._qet, b._qet);
       mergeSubtreePlanIds(plan, a, b);
-      return {plan};
+      return {std::move(plan)};
     } catch (const std::exception& e) {
       return {};
     }