Resolution plot updates with truth fitting examples #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
force-pushed
the
res-plots
branch
3 times, most recently
from
c35194b to
6fb42dd
Compare
niermann999
reviewed
Nov 1, 2023
examples/run/cpu/CMakeLists.txt
Outdated
| @@ -16,6 +16,10 @@ traccc_add_executable( truth_finding_example "truth_finding_example.cpp" | |||
| LINK_LIBRARIES vecmem::core detray::utils traccc::core traccc::io | |||
| traccc::performance traccc::options) | |||
|
|
|||
| traccc_add_executable( truth_fitting_example "truth_fitting_example.cpp" | |||
| LINK_LIBRARIES vecmem::core detray::utils traccc::core traccc::io | |||
There was a problem hiding this comment.
Maybe also link against detray::io explicitly (I guess it is part of traccc::io?)
| traccc::fitting_performance_writer::config{}); | ||
|
|
||
| // Output Stats | ||
| uint64_t n_fitted_tracks = 0; |
There was a problem hiding this comment.
Does it have to 64bits? Why not std::size_t?
There was a problem hiding this comment.
Changed it to std::size_t
| #include <TGraphErrors.h> | ||
| #endif // TRACCC_HAVE_ROOT | ||
|
|
||
| #include <iostream> |
|
|
||
| // Find index of eta and pT for resolution histogram | ||
| const scalar eta = getter::eta(ptc.mom); | ||
| const scalar pT = getter::perp(vector2{ptc.mom[0], ptc.mom[1]}); |
There was a problem hiding this comment.
Suggested change
| const scalar pT = getter::perp(vector2{ptc.mom[0], ptc.mom[1]}); | |
| const scalar pT = std::hypot(ptc.mom[0], ptc.mom[1]); |
| cache.ndf_hist = plot_helpers::book_histo("ndf", "NDF", b_ndf); | ||
| cache.chi2_hist = plot_helpers::book_histo("chi2", "Chi2", b_chi2); | ||
| cache.reduced_chi2_hist = | ||
| plot_helpers::book_histo("reduced_chi2", "Chi2/NDF", b_reduced_chi2); | ||
| cache.pval_hist = plot_helpers::book_histo("pval", "p value", b_pval); | ||
| for (unsigned int D = 1; D <= 2; D++) { |
There was a problem hiding this comment.
Suggested change
| for (unsigned int D = 1; D <= 2; D++) { | |
| for (unsigned int D = 1u; D <= 2u; D++) { |
beomki-yeo
force-pushed
the
res-plots
branch
3 times, most recently
from
ecbf5a0 to
8c579e7
Compare
niermann999
approved these changes
Nov 3, 2023
Comment on lines
+70
to
+75
| detray::material<scalar> mat; | ||
| if (!telescope_opts.empty_material) { | ||
| mat = detray::silicon<scalar>(); | ||
| } else { | ||
| mat = detray::vacuum<scalar>(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| detray::material<scalar> mat; | |
| if (!telescope_opts.empty_material) { | |
| mat = detray::silicon<scalar>(); | |
| } else { | |
| mat = detray::vacuum<scalar>(); | |
| } | |
| auto mat = telescope_opts.empty_material ? detray::vacuum<scalar>() : detray::silicon<scalar>(); |
There was a problem hiding this comment.
Seems the compiler is not smart enough
/home/beomki/projects/traccc/traccc/examples/simulation/simulate_telescope.cpp:71:40: error: operands to ‘?:’ have different types ‘detray::vacuum<float>’ and ‘detray::silicon<float>’
70 | detray::material<scalar> mat = telescope_opts.empty_material
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
71 | ? detray::vacuum<scalar>()
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
72 | : detray::silicon<scalar>();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some useful plots in
fitting_performanceand truth fitting examples. The PR is expected to be a milestone of new tag for ACTS workshop1. Measurement-level resolution (Figure: the p values of smoothed track parameters)
2. Residuals (Figure: residuals of q/p and q/p_T w.r.t eta)
3. Track-level resolution (Figure: sigma of q/p and q/p_T, gaussian fitting of residuals)
List of changes that are not implied by the title:
detail::get_event_filename()totraccc::io::get_event_filenamefitter_info)