Ref: Add concepts and restructure io directories #911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the io folder to make it easier to understand which classes are part of the backend and which belong to the frontend:
json_converter
. This way only the backend types are called "reader" and "writer"detray/core
Also factors out a function
read_components_from_file
from the detector reader, so that readers can be added to a detector construction workflow without calling theread_detector
function (e.g. if some components should be read from file, while others are built/converted directly).I tried to fix a nullptr dereferencing warning in the
surface_factory_interface
that appeared with gcc 14, but it seems to be a false positive