Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: Add concepts and restructure io directories #911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Jan 12, 2025

Restructure the io folder to make it easier to understand which classes are part of the backend and which belong to the frontend:

  • merge the json reader and writer to the json_converter. This way only the backend types are called "reader" and "writer"
  • rename the "common" folder to "backend"
  • move the detector related concepts to detray/core

Also factors out a function read_components_from_file from the detector reader, so that readers can be added to a detector construction workflow without calling the read_detector function (e.g. if some components should be read from file, while others are built/converted directly).

I tried to fix a nullptr dereferencing warning in the surface_factory_interface that appeared with gcc 14, but it seems to be a false positive

@niermann999 niermann999 force-pushed the ref-rename-converters branch 2 times, most recently from 8cb1d01 to d8c3a0a Compare January 12, 2025 18:40
Copy link

sonarqubecloud bot commented Jan 12, 2025

Quality Gate Passed Quality Gate passed

Issues
24 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@niermann999 niermann999 added refactor refactoring the current codes priority: low Low priority labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low priority refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant