Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: remove old template types on containers #908

Merged
merged 2 commits into from
Dec 20, 2024
Merged

ref: remove old template types on containers #908

merged 2 commits into from
Dec 20, 2024

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Dec 19, 2024 •
edited
Loading

Remove container template types that are not really used and rename std::array to darray everywhere in the core library. Also removes some leftover cmath includes

@niermann999 niermann999 added refactor refactoring the current codes priority: low Low priority labels Dec 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.5% Duplication on New Code

See analysis details on SonarQube Cloud

beomki-yeo
beomki-yeo approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niermann999 niermann999 merged commit 7816acc into acts-project:main Dec 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beomki-yeo beomki-yeo beomki-yeo approved these changes

Assignees
No one assigned
Labels
priority: low Low priority refactor refactoring the current codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niermann999 @beomki-yeo