Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use proto detector and proto volumes in svgtools illustrator #596

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

niermann999
Copy link
Contributor

This uses the actsvg proto classes for the detector and detector volumes as a prerequisite to transforming layer volumes into sheets. Also streamlines the styling and svg id naming a bit.

@niermann999 niermann999 added refactor refactoring the current codes priority: low Low priority labels Nov 20, 2023
@niermann999 niermann999 force-pushed the feat-rphiz-view branch 2 times, most recently from 61f0004 to 2bbae61 Compare November 20, 2023 19:55
@niermann999 niermann999 force-pushed the feat-rphiz-view branch 3 times, most recently from c8d830d to e2b02cd Compare November 20, 2023 21:14
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@niermann999 niermann999 merged commit 9bc88df into acts-project:main Nov 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low priority refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants