Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove the use of infinitiy #594

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

niermann999
Copy link
Contributor

Remove the use of inifity and replace it with detray invalid value (which is numeric max)

@niermann999 niermann999 added bug Something isn't working refactor refactoring the current codes priority: low Low priority labels Nov 15, 2023
@niermann999 niermann999 linked an issue Nov 15, 2023 that may be closed by this pull request
@niermann999 niermann999 marked this pull request as ready for review November 15, 2023 15:44
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@niermann999 niermann999 force-pushed the ref-remove-inf branch 3 times, most recently from f903961 to 4d31735 Compare November 16, 2023 21:17
…hich is numeric max).

Also move function is_invalid_value to datail namespace.
@niermann999 niermann999 changed the title ref: remove the use of inifitiy ref: remove the use of infinitiy Nov 16, 2023
@niermann999 niermann999 merged commit 4692629 into acts-project:main Nov 16, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: low Low priority refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of infinities
2 participants