ref: rename surface store #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should not have an effect on traccc |
niermann999
force-pushed
the
feat-sf-lookup
branch
from
49f040c to
110b570
Compare
pass it to the surface descriptor in the IO. Also fixes the type ids to 8bits.
niermann999
force-pushed
the
feat-sf-lookup
branch
from
110b570 to
5c4bf39
Compare
|
This is the first step in refactoring the surface lookup, so that we can get |
beomki-yeo
pushed a commit
to beomki-yeo/detray
that referenced
this pull request
Oct 24, 2023
After the merging of the surface acceleration structures with the surface vector did not work, this PR restores the naming of the data stores. Also correctly passes the source links on to the surfaces in the geometry IO and restricts the type ids to 8bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merging of the surface acceleration structures with the surface vector did not work, this PR restores the naming of the data stores. Also correctly passes the source links on to the surfaces in the geometry IO and restricts the type ids to 8bits