Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate svgtools #571

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: integrate svgtools #571

merged 1 commit into from
Oct 27, 2023

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Oct 19, 2023 •
edited
Loading

First step in using the new svgtools plugin: Add an executable to the validation suite that reads in a detector from file and displays it either whole or given by volume/surface indices. Can additionally export the detector to dot, which shows the navigation graph structure of the detector.

@niermann999 niermann999 added enhancement New feature or request priority: medium medium priority labels Oct 19, 2023
@niermann999 niermann999 marked this pull request as draft October 19, 2023 15:10
@niermann999
Copy link
Contributor Author

niermann999 commented Oct 19, 2023 •
edited
Loading

Based on #567

@niermann999 niermann999 force-pushed the feat-integrate-svgtools branch 2 times, most recently from c899fd9 to d8a3aad Compare October 20, 2023 11:39
@niermann999
Copy link
Contributor Author

toy_detector_volume_display_xy
toy_detector_display_zr

@niermann999
Copy link
Contributor Author

toy_detector_volume_graph.pdf

@niermann999 niermann999 force-pushed the feat-integrate-svgtools branch from d8a3aad to f426fd4 Compare October 20, 2023 12:27
@niermann999 niermann999 marked this pull request as ready for review October 20, 2023 12:27
@niermann999 niermann999 force-pushed the feat-integrate-svgtools branch from f426fd4 to 52b32ab Compare October 20, 2023 12:55
@niermann999 niermann999 mentioned this pull request Oct 21, 2023
Merged
@niermann999 niermann999 added blocked This item is blocked by another item and removed blocked This item is blocked by another item labels Oct 21, 2023
@niermann999 niermann999 force-pushed the feat-integrate-svgtools branch 2 times, most recently from b317d37 to 51dcac2 Compare October 25, 2023 07:38
@niermann999 niermann999 force-pushed the feat-integrate-svgtools branch 2 times, most recently from 6014200 to bf7bd47 Compare October 25, 2023 14:01
@niermann999 niermann999 force-pushed the feat-integrate-svgtools branch from bf7bd47 to d2df63e Compare October 27, 2023 08:22
asalzburger
asalzburger approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with this.

Fitting: the introduction of the pumpkin color.

@asalzburger asalzburger merged commit f43b3ed into acts-project:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

@beomki-yeo beomki-yeo Awaiting requested review from beomki-yeo

Assignees
No one assigned
Labels
enhancement New feature or request priority: medium medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niermann999 @asalzburger