Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Add device container specializations for the view type handling #569

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Oct 19, 2023

This should enable to use the local view_type of either the device or the host class. After the removal of the detector_view type, which did not do any checking, the detector::view_type now passes the type checks correctly.
Also added a few static asserts and unittests

@niermann999 niermann999 added bug Something isn't working refactor refactoring the current codes labels Oct 19, 2023
@niermann999 niermann999 force-pushed the ref-use-devie-view branch 4 times, most recently from e54fe9a to cf66942 Compare October 19, 2023 14:08
@niermann999 niermann999 marked this pull request as ready for review October 19, 2023 14:12
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@beomki-yeo beomki-yeo merged commit a8b7593 into acts-project:main Oct 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants