MSVC Fix, main branch (2024.11.21.) #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the benchmark build work correctly with MSVC. After #131 we collected the following type of warnings into our CI:
Note that I completely removed
-ftree-vectorize
, and only kept-march=native
behind a check that makes sure that the compiler would accept that flag.Since forever
-ftree-vectorize
is part of-O3
with GCC. (https://gcc.gnu.org/projects/tree-ssa/vectorization.html) So to use auto-vectorization, just use-DCMAKE_BUILD_TYPE=Release
. Which should anyway be mandatory for benchmarking... 🤔