Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC Fix, main branch (2024.11.21.) #138

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

krasznaa
Copy link
Member

Made the benchmark build work correctly with MSVC. After #131 we collected the following type of warnings into our CI:

     Creating library D:/a/algebra-plugins/algebra-plugins/build/lib/Debug/benchmark.lib and object D:/a/algebra-plugins/algebra-plugins/build/lib/Debug/benchmark.exp
  benchmark.vcxproj -> D:\a\algebra-plugins\algebra-plugins\build\bin\Debug\benchmark.dll
  Building Custom Rule D:/a/algebra-plugins/algebra-plugins/benchmarks/CMakeLists.txt
cl : command line  warning D9002: ignoring unknown option '-march=native' [D:\a\algebra-plugins\algebra-plugins\build\benchmarks\algebra_benchmark_array_getter.vcxproj]
cl : command line  warning D9002: ignoring unknown option '-ftree-vectorize' [D:\a\algebra-plugins\algebra-plugins\build\benchmarks\algebra_benchmark_array_getter.vcxproj]

Note that I completely removed -ftree-vectorize, and only kept -march=native behind a check that makes sure that the compiler would accept that flag.

Since forever -ftree-vectorize is part of -O3 with GCC. (https://gcc.gnu.org/projects/tree-ssa/vectorization.html) So to use auto-vectorization, just use -DCMAKE_BUILD_TYPE=Release. Which should anyway be mandatory for benchmarking... 🤔

@krasznaa krasznaa added the bug Something isn't working label Nov 21, 2024
@krasznaa krasznaa requested a review from niermann999 November 21, 2024 14:57
@krasznaa krasznaa merged commit c044b83 into acts-project:main Nov 22, 2024
25 checks passed
@krasznaa krasznaa deleted the MSVCFix-main-20241121 branch November 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants