feat: Introduce concepts #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-concepts
branch
6 times, most recently
from
87e5bd6 to
e2b885c
Compare
niermann999
force-pushed
the
feat-concepts
branch
3 times, most recently
from
0df3532 to
d55193d
Compare
niermann999
force-pushed
the
feat-concepts
branch
from
d55193d to
ff45ff5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
feat-concepts
branch
5 times, most recently
from
e90ad47 to
9c595c2
Compare
krasznaa
approved these changes
Nov 25, 2024
|
Did you rebase on top of the latest SYCL changes? I fear that this repository still doesn't require PRs to have run their CI on top of the tip of the |
niermann999
force-pushed
the
feat-concepts
branch
from
9c595c2 to
ba6fb15
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds concepts for the main linear algebra types and constrains as many template parameters as possible. Also switches out the
std::enable_ifinstances againstrequiresclauses