fix: Centre from confex face in Annulus

[paulgessinger]

Fixes a small error where the last vertex was being ignore for Annulus shapes.

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

• Use a conventional commits prefix: quick summary
  • We mostly use feat, fix, refactor, docs, chore and build types.
• A milestone will be assigned by one of the maintainers

Summary by CodeRabbit

• Refactor
  • Improved the internal logic for surface rendering by switching to a dynamic option for including a central geometric feature. This update allows the system to adapt to varying conditions, resulting in more accurate and reliable representations. Users should benefit from enhanced performance during complex graphical operations as internal computations are better optimized.

[coderabbitai]

Walkthrough

Changed in DiscSurface.cpp, it has been. In the polyhedronRepresentation method, the hardcoded true passed to convexFaceMesh is replaced with the variable addCentreFromConvexFace, determined earlier from the m_bounds state. The overall structure and logic remain preserved, yes.

Changes

File(s)	Change Summary
Core/.../DiscSurface.cpp	In polyhedronRepresentation, the call to convexFaceMesh(vertices, true) is updated to use the variable addCentreFromConvexFace instead of a fixed true.

Sequence Diagram(s)

sequenceDiagram
    participant PS as polyhedronRepresentation
    participant FHS as convexFaceMesh
    PS->>FHS: Call with vertices, addCentreFromConvexFace

Loading

Suggested labels

Component - Examples, automerge

Suggested reviewers

• benjaminhuth

Poem

Mmm, a subtle change in code, we see,
True replaced by a variable, dynamic it shall be.
In DiscSurface the flow now sings,
A refactored dance that new logic brings.
With the Force of clean code, may our work ever be.

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51ed39b and afd671c.

📒 Files selected for processing (1)

• Core/src/Surfaces/DiscSurface.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: merge-sentinel
• GitHub Check: CI Bridge / lcg_106a: [alma9, clang16]
• GitHub Check: CI Bridge / lcg_106a: [alma9, gcc14]
• GitHub Check: CI Bridge / lcg_106a: [alma9, gcc13]
• GitHub Check: CI Bridge / build_gnn_tensorrt
• GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
• GitHub Check: CI Bridge / lcg_105: [alma9, clang16]
• GitHub Check: CI Bridge / linux_ubuntu_2204_clang
• GitHub Check: CI Bridge / build_exatrkx
• GitHub Check: CI Bridge / linux_ubuntu_2204
• GitHub Check: CI Bridge / build_linux_ubuntu
• GitHub Check: unused_files
• GitHub Check: CI Bridge / build_exatrkx_cpu
• GitHub Check: CI Bridge / clang_tidy
• GitHub Check: macos
• GitHub Check: missing_includes
• GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, clang++)
• GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
• GitHub Check: linux_ubuntu
• GitHub Check: build_debug

🔇 Additional comments (2)

Core/src/Surfaces/DiscSurface.cpp (2)

162-162: Wise decision, this variable initialization is!

Correctly determine whether to add center from convex face based on bounds type, you now do. For Annulus shapes, special handling needed it was.

---

179-180: Fixed, the issue with last vertex in Annulus shapes now is!

Pass the dynamic flag instead of hardcoded true, we now do. Properly handle all shape types, this change does.

Verify the impact on Annulus shapes, we must:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for tests involving Annulus shapes to ensure proper coverage
rg -l "Annulus" --type cpp tests/

Length of output: 80

---

I sense the tests for Annulus shapes remain hidden, hmmm. We must search the repository more widely for any test coverage. I shall now generate new scripts to look for potential test directories and search for any mentions of "Annulus" outside of the non-existent tests/ directory.

---

🏁 Script executed:

#!/bin/bash
echo "Finding all potential test directories in repository:"
find . -type d -iname "*test*"

echo "Searching for 'Annulus' mentions throughout the repository:"
rg -l "Annulus"

Length of output: 2751

---

Impact on Annulus shapes appears verified, hmmm.

The repository does indeed contain tests covering annulus shapes – notably in the file Tests/UnitTests/Core/Surfaces/AnnulusBoundsTests.cpp (and related test files). These tests should ensure that the dynamic flag change in Core/src/Surfaces/DiscSurface.cpp correctly handles the last vertex issue in annulus shapes.

May the Force be with your changes.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

📊: Physics performance monitoring for 48a89e9

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[acts-project-service]

✅ Athena integration test results [f5c726b]

✅ All tests successful

status	job	report
🟢	report_pull_request
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsWorkflowHgtd
🟢	test_ActsCheckObjectCountsCachedWorkflow
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGx2fRefitting
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest