refactor: Do not insert space points if not inside grid boundaries #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
reviewed
Oct 9, 2024
CarloVarni
commented
Oct 9, 2024
andiwand
approved these changes
Oct 9, 2024
|
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…cts-project#3698) Changes: - Calling `grid.isInside` to check if space point falls within the boundaries - Check min and max values are correct (i.e. min < max) - Additional changes to check phi is within `[-std::numbers::pi`, `std::numbers::pi`] - Move config and options values to `double` (also because units are `double`s). Only partial since moving them all requires change in other parts of the code (will follow up in another PR) - Use `std::numbers::pi` instead of `M_PI` In the example, we go back to the previous computation for the `rMiddleSPRange`. Not clear why the `std::floor` was introduced in the first place, going back to that computation while we figure out why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
grid.isInsideto check if space point falls within the boundaries[-std::numbers::pi,std::numbers::pi]double(also because units aredoubles). Only partial since moving them all requires change in other parts of the code (will follow up in another PR)std::numbers::piinstead ofM_PIIn the example, we go back to the previous computation for the
rMiddleSPRange. Not clear why thestd::floorwas introduced in the first place, going back to that computation while we figure out why