Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update compiler warning flags #3495

Merged
merged 28 commits into from
Aug 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
37aca5f
ci: Update LCG versions
paulgessinger Aug 16, 2024
f6e3055
make podio compat use new IO names for 0.99.0
paulgessinger Aug 16, 2024
9015b71
forgot a preprocessor condition
paulgessinger Aug 16, 2024
b67eb49
actually, tighten the condition up some more
paulgessinger Aug 16, 2024
080a9a8
and fix a typo
paulgessinger Aug 16, 2024
8bf797c
drop lcg 106, add error for boost 1.85.0
paulgessinger Aug 19, 2024
554b0cf
Merge remote-tracking branch 'origin/main' into ci/update-lcg-versions
paulgessinger Aug 19, 2024
89c6ee8
chore: Remove unused-local-typedefs
paulgessinger Aug 8, 2024
0a9e339
chore: Remove old-style casts
paulgessinger Aug 8, 2024
ce4fd90
build: Update compiler warning flags
paulgessinger Aug 8, 2024
8e460c3
remove possible nullptr dereferences
paulgessinger Aug 14, 2024
b5c7270
fix incorrect removal of typedef
paulgessinger Aug 14, 2024
b8f5cff
compile fixes after warnings added
paulgessinger Aug 14, 2024
682bd81
avoid unused warnings for iterator typedefs
paulgessinger Aug 14, 2024
0558dd0
bump ODD version to v4.0.2
paulgessinger Aug 14, 2024
a61ea06
add patch for traccc until old-style-cast warning is fixed
paulgessinger Aug 16, 2024
9eb2c31
disable traccc google benchmark build
paulgessinger Aug 16, 2024
36f9e8d
add in traccc patch for null dereference
paulgessinger Aug 16, 2024
c14fc4c
fix one more null-dereference case
paulgessinger Aug 16, 2024
9b08ca4
one more null-dereference case fixed
paulgessinger Aug 16, 2024
1e54f9f
only apply -Wnull-dereference on GCC<13
paulgessinger Aug 16, 2024
48a26ee
fix a few GCC12 build issues
paulgessinger Aug 16, 2024
3c909ef
fix another null deref in edm4hep reader
paulgessinger Aug 16, 2024
6e31384
make pre-commit ignore .diff and .patch files
paulgessinger Aug 16, 2024
379a385
Merge branch 'main' into chore/warning-reduction
paulgessinger Aug 20, 2024
99b74f3
Merge branch 'main' into chore/warning-reduction
kodiakhq[bot] Aug 20, 2024
4b7b772
Merge branch 'main' into chore/warning-reduction
paulgessinger Aug 20, 2024
bd96716
Merge branch 'main' into chore/warning-reduction
kodiakhq[bot] Aug 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drop lcg 106, add error for boost 1.85.0
paulgessinger committed Aug 19, 2024
commit 8bf797c7a1573e52862f8c8f231f192d8d5c53fc
12 changes: 0 additions & 12 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
@@ -385,15 +385,3 @@ lcg_105:
COMPILER:
- gcc13
- clang16

lcg_106:
<<: *lcg_base_job

variables:
LCG_VERSION: "106"

parallel:
matrix:
- OS: [alma9]
COMPILER:
- gcc13
10 changes: 10 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -234,6 +234,16 @@ if (ACTS_SETUP_BOOST)
if(Boost_VERSION VERSION_LESS _acts_boost_recommended_version)
message(WARNING "Found Boost ${Boost_VERSION} - recommended is at least ${_acts_boost_recommended_version}")
endif()

if(Boost_VERSION VERSION_EQUAL "1.85.0")
set(message "Boost 1.85.0 is known to be broken (https://github.com/boostorg/container/issues/273). Please use a different version.")
if(ACTS_IGNORE_BOOST_1850_ERROR)
message(WARNING ${message})
else()
message(SEND_ERROR ${message})
endif()
endif()

endif()

if (ACTS_SETUP_EIGEN3)