feat: Add covfie magnetic field plugin

[stephenswat]

This commit adds a new Acts plugin that adds support for magnetic fields implemented using the covfie library.

This commit is based on #3117.

Closes #3117.

Depends on #3478.

Virtually all credit goes to @fredevb.

[paulgessinger]

Can you update the branch? I'll look at this today

[stephenswat]

This is now ready for review.

[github-actions]

📊: Physics performance monitoring for 37d0332

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ CKF | trackfinding | single muon | truth smeared seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF | trackfinding | single muon | truth estimated seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF | trackfinding | single muon | default seeding
• ✅ Track Summary CKF | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF | trackfinding | single muon | orthogonal seeding
• ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[stephenswat]

@paulgessinger I have incorporated your feedback and rebased.

[paulgessinger]

I'm not completely sure I understand how you get around the out-of-bounds field access with the interpolated fields now.

[stephenswat]

I'm not completely sure I understand how you get around the out-of-bounds field access with the interpolated fields now.

The core problem is that ACTS won't allow me to access the points at the edge of a B-field. In a one-dimensional example, if I define a data series as $[2, 3, 2, 1]$, I can ask ACTS for the position at $x = 0$ and get $f(0) = 2$; I can also ask for e.g. $f(1.5) = 2.5$. But I cannot ask for $f(3)$ (which would be $1$) because of this line: https://github.com/acts-project/acts/blob/main/Core/include/Acts/MagneticField/InterpolatedBFieldMap.hpp#L256. Because $3$ is the boundary and the convention is that the range is half-open, this returns an error. My understanding is that this is by design.

The way I have solved (c.q. hacked) this is by asking for $f(0)$, $f(1)$, $f(2)$ as normal and then - when I get to $x = 3$, asking for $f(x')$ where $x'$ is the closest representable number that is smaller than $3$; so I end up asking for $f(2.999999999)$ or something like that.

Not super clean (actually quite disgusting) but it works. I investigated accessing the underlying grid directly, but this is not generally supported by ACTS B-field classes, unfortunately.

[stephenswat]

I've resolved the comment issues; I've left them in even if they are not necessary because, well, why not. 😄

[paulgessinger]

Ok, looks good. There's a few CI failures that need fixing, otherwise it's good to go I think.

[paulgessinger]

There's just one remaining clang tidy item about inconsistent argument names between declaration and definition.

[sonarqubecloud]

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
67.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

✅ Athena integration test results [809b378]

✅ All tests successful

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsCachedWorkflow
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_unit_tests