feat(awc): allow to configure connector per request #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: This pr has been rebased on #3522 so we can benefit from the pool key being determined by the connect object (instead of authority) |
joelwurtz
force-pushed
the
feat/allow-to-configure-connector-per-request
branch
2 times, most recently
from
9c96b24 to
c7b0c06
Compare
…gure connect config per request
joelwurtz
force-pushed
the
feat/allow-to-configure-connector-per-request
branch
from
c7b0c06 to
610dd61
Compare
robjtede
added
A-awc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
Goal of this PR is to allow configure some connector options per request instead of needed different clients
It's not finished but i'm wondering how far this should go.
Since it's based on #3522 it allow to have a different pool on different conn life time or other config (like h2 windows size) which will be better as it ensure proper connection option.