Class label test fix #2998
Merged
Class label test fix #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activesoull
force-pushed
the
class_label_test_fix
branch
from
62d6afc to
c033619
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
khustup2
reviewed
Nov 26, 2024
| @@ -49,7 +49,8 @@ def test_multi_source_query(hub_cloud_dev_token): | |||
| 'SELECT * FROM (SELECT * FROM "hub://activeloop/mnist-train" UNION (SELECT images, labels FROM "hub://activeloop/cifar100-train")) WHERE labels == 0', | |||
| token=hub_cloud_dev_token, | |||
| ) | |||
| assert len(ds) == 6423 | |||
There was a problem hiding this comment.
I get why the result of this test was changed. Can you please add the following test too?
ds = deeplake.query(
'SELECT * FROM "hub://activeloop/mnist-train" WHERE labels == 0 UNION (SELECT images, labels FROM "hub://activeloop/cifar100-train" WHERE labels == 0)',
token=hub_cloud_dev_token,
)
assert len(ds) == 6423
khustup2
approved these changes
Nov 26, 2024
nvoxland-al
approved these changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context