Updated docker documentation and db container name to avoid confusion with db volume #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put link to rita_docker.yaml so that people don't accidentally use rita.yaml, which will not work for docker compose setup.
Change container name db to mongo-db for clarity and avoid overlap with docker volume of the same name.
Change container name "db" to "mongo-db" to avoid confusion and overlap with volume "db". Change is also reflected in updated rita_docker.yaml
|
+1, helpful improvements. May also relate to #796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #807, updated docker compose usage documentation to explicitly mention that users should use "rita_docker.yaml" and not "rita.yaml" as the template. Additionally, renamed the mongodb container name from "db" to mongo-db to avoid confusion and overlap with the db volume also used in the docker-compose.yml.