Update to rules format 1.1 #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosapaduarte
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
The preamble of the rule-design document (pages/design/rule-design.md) still had a mention of the rule format 1.0. I've updated it with this commit
dan-tripp-siteimprove
approved these changes
Oct 24, 2024
WilcoFiers
commented
Oct 24, 2024
HelenBurge
approved these changes
Oct 31, 2024
WilcoFiers
added
the
Review call 2 weeks
colabottles
approved these changes
Nov 4, 2024
kengdoj
requested changes
Nov 4, 2024
|
|
||
| - [rule name here](./abc123) | ||
|
|
||
| ### Bibliography |
There was a problem hiding this comment.
I think "Bibliography" under Background should be "Other Resources".
| - **Failed:** A [test target](https://www.w3.org/TR/act-rules-format/#test-target) does not meet all expectations | ||
| - **Passed:** A [test target][] meets all expectations | ||
| - **Failed:** A [test target][] does not meet all expectations | ||
| - **cantTell:** Whether the rule is applicable, or not all expectations were met could not be fully determined by the tester. |
There was a problem hiding this comment.
Suggested change
| - **cantTell:** Whether the rule is applicable, or not all expectations were met could not be fully determined by the tester. | |
| - **cantTell:** Whether the rule is applicable, or whether all expectations were met could not be fully determined by the tester. |
There was a problem hiding this comment.
We should make this change in the rules format first.
| - **Passed:** A [test target][] meets all expectations | ||
| - **Failed:** A [test target][] does not meet all expectations | ||
| - **cantTell:** Whether the rule is applicable, or not all expectations were met could not be fully determined by the tester. | ||
| - **Untested**: The tester has not attempted to evaluate the test subject. |
There was a problem hiding this comment.
Suggested change
| - **Untested**: The tester has not attempted to evaluate the test subject. | |
| - **Untested**: The test subject was not evaluated for the rule. |
kengdoj
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_formatproperty to the page front matterNeed for Call for Review: 2 weeks, this is a substantial change
How to Review And Approve