-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify tsconfig, build & lint #72
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
843ca23
simplify tsconfig, build & lint
gsteenkamp89 a51cf4e
fix
gsteenkamp89 d574d0a
build with tsc only
gsteenkamp89 6f6ee52
resolve modules without a bundler
gsteenkamp89 9efb854
include test folder in type checking in lint step
gsteenkamp89 2f53e66
no unused locals in sdk only
gsteenkamp89 5f1102e
fix ci script
gsteenkamp89 c8a3e7b
small fixes
gsteenkamp89 5834448
fix
gsteenkamp89 1f8b643
fix ci pipeline
gsteenkamp89 3ae26d9
ignore specific rule for unused var in signUpdateDeposit
gsteenkamp89 0f30105
add changeset
gsteenkamp89 91df677
manually override secp256k1
gsteenkamp89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@across-protocol/app-sdk": patch | ||
--- | ||
|
||
Simplify build using tsc for a more tree-shakable, unbundled output. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"name": "across-toolkit", | ||
"private": true, | ||
"scripts": { | ||
"build": "turbo build", | ||
|
@@ -19,8 +20,12 @@ | |
"turbo": "^2.1.0" | ||
}, | ||
"packageManager": "[email protected]", | ||
"pnpm": { | ||
"overrides": { | ||
"secp256k1": "^>=5.0.1" | ||
} | ||
}, | ||
"engines": { | ||
"node": ">=18" | ||
}, | ||
"name": "across-toolkit" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"root": true, | ||
"extends": ["@across-toolkit/eslint-config/library.js"], | ||
"parser": "@typescript-eslint/parser", | ||
"parserOptions": { | ||
"project": true | ||
}, | ||
"env": { | ||
"es2020": true | ||
} | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
export * from "./getSuggestedFees"; | ||
export * from "./getAvailableRoutes"; | ||
export * from "./getLimits"; | ||
export * from "./getQuote"; | ||
export * from "./simulateDepositTx"; | ||
export * from "./waitForDepositTx"; | ||
export * from "./getFillByDepositTx"; | ||
export * from "./getDeposit"; | ||
export * from "./getDepositFromLogs"; | ||
export * from "./waitForFillTx"; | ||
export * from "./simulateApproveTx"; | ||
export * from "./executeQuote"; | ||
export * from "./getSuggestedFees.js"; | ||
export * from "./getAvailableRoutes.js"; | ||
export * from "./getLimits.js"; | ||
export * from "./getQuote.js"; | ||
export * from "./simulateDepositTx.js"; | ||
export * from "./waitForDepositTx.js"; | ||
export * from "./getFillByDepositTx.js"; | ||
export * from "./getDeposit.js"; | ||
export * from "./getDepositFromLogs.js"; | ||
export * from "./waitForFillTx.js"; | ||
export * from "./simulateApproveTx.js"; | ||
export * from "./executeQuote.js"; | ||
export * from "./simulateUpdateDepositTx.js"; | ||
export * from "./signUpdateDeposit.js"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there is some rule to enforce the
.js
extension when importing? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe TSC will complain if you don't do it, while "module" is set to "NodeNext" in the tsconfig.