Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/optional integrator #22

Merged
merged 2 commits into from
Sep 30, 2024
Merged

hotfix/optional integrator #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d18d8f3
make integratorId optional in constructor
gsteenkamp89 Sep 30, 2024
a4b2373
set default to sdk name for meaningful tracking
gsteenkamp89 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/sdk/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import {

const CLIENT_DEFAULTS = {
pollingInterval: 3_000,
integratorId: "INTEGRATOR_SDK",
logLevel: "ERROR",
} as const;

Expand All @@ -65,7 +66,7 @@ export type AcrossClientOptions = {
/**
* An identifier representing the integrator.
*/
integratorId: string;
integratorId?: string;
/**
* The chains to use for the Across API. Should be imported from `viem/chains`.
*/
Expand Down Expand Up @@ -179,7 +180,7 @@ export class AcrossClient {
* @internal
*/
private constructor(args: AcrossClientOptions) {
this.integratorId = args.integratorId;
this.integratorId = args?.integratorId ?? CLIENT_DEFAULTS.integratorId;
this.walletClient = args?.walletClient;
this.publicClients = configurePublicClients(
args.chains,
Expand Down