fix: use on-chain current time for fillDeadline calc (#45)

* fix: use on-chain current time for `fillDeadline` calc * chore: add changeset
across-protocol · Oct 8, 2024 · 78e0b66 · 78e0b66
1 parent a086a2f
commit 78e0b66
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 11 deletions.
diff --git a/.changeset/unlucky-cups-serve.md b/.changeset/unlucky-cups-serve.md
@@ -0,0 +1,5 @@
+---
+"@across-protocol/app-sdk": patch
+---
+
+fix `fillDeadline` calculation
diff --git a/packages/sdk/src/actions/simulateDepositTx.ts b/packages/sdk/src/actions/simulateDepositTx.ts
@@ -6,11 +6,7 @@ import {
   zeroAddress,
 } from "viem";
 import { Quote } from "./getQuote";
-import {
-  getCurrentTimeSeconds,
-  getIntegratorDataSuffix,
-  LoggerT,
-} from "../utils";
+import { getIntegratorDataSuffix, LoggerT } from "../utils";
 import { spokePoolAbi } from "../abis/SpokePool";
 
 export type SimulateDepositTxParams = {
@@ -62,12 +58,30 @@ export async function simulateDepositTx(params: SimulateDepositTxParams) {
   let fillDeadline = _fillDeadline;
 
   if (!fillDeadline) {
-    const fillDeadlineBuffer = await publicClient.readContract({
-      address: spokePoolAddress,
-      abi: spokePoolAbi,
-      functionName: "fillDeadlineBuffer",
-    });
-    fillDeadline = getCurrentTimeSeconds() - 60 + fillDeadlineBuffer;
+    const [fillDeadlineBufferResult, getCurrentTimeResult] =
+      await publicClient.multicall({
+        contracts: [
+          {
+            address: spokePoolAddress,
+            abi: spokePoolAbi,
+            functionName: "fillDeadlineBuffer",
+          },
+          {
+            address: spokePoolAddress,
+            abi: spokePoolAbi,
+            functionName: "getCurrentTime",
+          },
+        ],
+      });
+    if (fillDeadlineBufferResult.error || getCurrentTimeResult.error) {
+      const error =
+        fillDeadlineBufferResult.error || getCurrentTimeResult.error;
+      throw new Error(
+        `Failed to fetch 'fillDeadlineBuffer' or 'getCurrentTime': ${error}`,
+      );
+    }
+    fillDeadline =
+      Number(getCurrentTimeResult.result) + fillDeadlineBufferResult.result;
   }
 
   const useExclusiveRelayer =