fix(RelayFeeCalculator): Return maxFeePerGas rather than tokenGasCost / nativeGasCost #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… / nativeGasCost If we divide `tokenGasCost / nativeGasCost` then we'll get the L1GasCost + L2GasPrice components for the gas price for OpStack, because OpStack adds this L1GasCost component to the full total gas cost. The SDK should return the `gasPrice = baseFee + priorityFee` to help with debugging against the API, for example against this PR across-protocol/frontend#1335
pxrl
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we divide
tokenGasCost / nativeGasCostthen we'll get the L1GasCost + L2GasPrice components for the gas price for OpStack, because OpStack adds this L1GasCost component to the full total gas cost.The SDK should return the
gasPrice = baseFee + priorityFeeto help with debugging against the API, for example against this PR across-protocol/frontend#1335