chore: remove rails around inverting capital cost config (#703)

Signed-off-by: james-a-morris <[email protected]>
across-protocol · Aug 16, 2024 · 609cf4a · 609cf4a
1 parent 02c86f9
commit 609cf4a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 29 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@across-protocol/sdk",
   "author": "UMA Team",
-  "version": "3.1.24",
+  "version": "3.1.25",
   "license": "AGPL-3.0",
   "homepage": "https://docs.across.to/reference/sdk",
   "files": [

diff --git a/src/relayFeeCalculator/relayFeeCalculator.ts b/src/relayFeeCalculator/relayFeeCalculator.ts
@@ -196,7 +196,6 @@ export class RelayFeeCalculator {
    */
   static validateCapitalCostsConfig(capitalCosts: CapitalCostConfig): void {
     assert(toBN(capitalCosts.upperBound).lt(toBNWei("0.01")), "upper bound must be < 1%");
-    assert(toBN(capitalCosts.lowerBound).lte(capitalCosts.upperBound), "lower bound must be <= upper bound");
     assert(capitalCosts.decimals > 0 && capitalCosts.decimals <= 18, "invalid decimals");
   }
 

diff --git a/test/relayFeeCalculator.test.ts b/test/relayFeeCalculator.test.ts
@@ -7,7 +7,6 @@ import {
   toGWei,
   TransactionCostEstimate,
   bnOne,
-  bnZero,
   getCurrentTime,
   spreadEvent,
   isMessageEmpty,
@@ -194,29 +193,6 @@ describe("RelayFeeCalculator", () => {
         }),
       /upper bound must be </
     );
-    assert.throws(
-      () =>
-        new RelayFeeCalculator({
-          queries,
-          capitalCostsConfig: {
-            WBTC: {
-              ...testCapitalCostsConfig["WBTC"],
-              upperBound: toBNWei("0.001").toString(),
-              lowerBound: toBNWei("0.002").toString(),
-            },
-          },
-        }),
-      /lower bound must be <= upper bound/
-    );
-    assert.throws(
-      () =>
-        RelayFeeCalculator.validateCapitalCostsConfig({
-          ...testCapitalCostsConfig["WBTC"],
-          upperBound: toBNWei("0.001").toString(),
-          lowerBound: toBNWei("0.002").toString(),
-        }),
-      /lower bound must be <= upper bound/
-    );
     assert.throws(
       () =>
         new RelayFeeCalculator({
@@ -359,11 +335,11 @@ describe("RelayFeeCalculator: Composable Bridging", function () {
           originChainId: 10,
           destinationChainId: 1,
           message: message || EMPTY_MESSAGE,
-          relayerFeePct: bnZero,
-          realizedLpFeePct: bnZero,
           exclusiveRelayer: ZERO_ADDRESS,
           fillDeadline: getCurrentTime() + 60000,
           exclusivityDeadline: 0,
+          fromLiteChain: false,
+          toLiteChain: false,
         },
         1,
         false,
@@ -448,7 +424,7 @@ describe("RelayFeeCalculator: Composable Bridging", function () {
         originChainId: 1,
         message: "0xabcdef",
         exclusiveRelayer: ZERO_ADDRESS,
-        fillDeadline: getCurrentTime() + 60,
+        fillDeadline: getCurrentTime() + 600,
         exclusivityDeadline: 0,
       },
       10