fix(IndexedSpokePoolClient): Cast depositId correctly #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be safe, log a known BN as a string
nicholaspai
requested review from
mrice32,
pxrl,
james-a-morris,
dohaki and
bmzig
as code owners
nicholaspai
changed the title
bmzig
previously approved these changes
Jan 27, 2025
pxrl
previously approved these changes
Jan 27, 2025
bmzig
reviewed
Jan 27, 2025
bmzig
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpokePoolClient doesn't set depositId correctly in a rare case.
Also, to be safe, log a known BN as a string where we currently don't do so