Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use new atomic depositor in adapters #1852

Merged
merged 51 commits into from
Feb 11, 2025
Merged

Conversation

bmzig
Copy link
Contributor

@bmzig bmzig commented Oct 7, 2024

This updates the adapters to use the new atomic depositor.

@bmzig bmzig added the do not merge Don't merge until label is removed label Oct 7, 2024
pxrl
pxrl previously approved these changes Oct 25, 2024
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmzig LGTM. Have you tested each of these deposit routes?

@pxrl
Copy link
Contributor

pxrl commented Oct 25, 2024

One additional thought - it'd be nice with a script to ease the process of adding new chains.

Base automatically changed from npai/atomic-weth-depositor to master October 25, 2024 15:59
An error occurred while trying to automatically change base from npai/atomic-weth-depositor to master October 25, 2024 15:59
bmzig and others added 4 commits October 25, 2024 11:00
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
@bmzig
Copy link
Contributor Author

bmzig commented Jan 10, 2025

Reployed at https://etherscan.io/address/0x64668fbd18b967b46dd22dc8675134d91efedd8d so that we could accommodate custom gas token bridges. It has been configured and tested for the following 12 chains:
Optimism: init recv
World Chain: init recv
Redstone: init recv
Lisk: init recv
Base: init recv
Blast: init recv
Mode: init recv
Zora: init recv
Linea: init recv
Polygon: init recv
ZkSync: init recv
Ink init recv

I can confirm that transfer tracking works as expected for all of these deposits.

bmzig added 2 commits January 16, 2025 09:59
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
@bmzig
Copy link
Contributor Author

bmzig commented Jan 16, 2025

Soneium init and recv

@bmzig bmzig requested a review from james-a-morris January 16, 2025 16:58
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this impact any logs emitted and tracked in the outstanding cross chain transaction checks?

nicholaspai
nicholaspai previously approved these changes Feb 10, 2025
bmzig and others added 2 commits February 11, 2025 09:15
@bmzig
Copy link
Contributor Author

bmzig commented Feb 11, 2025

Unichain init and recv. Using the new atomic depositor is opt-out for op stack chains only, meaning that we will use it for ZkSync/Linea, and can choose to not use it for select OpStack chains. This opt-out should be temporary, since we want to fully migrate whever possible.

nicholaspai
nicholaspai previously approved these changes Feb 11, 2025
Signed-off-by: bennett <bennett@umaproject.org>
@bmzig
Copy link
Contributor Author

bmzig commented Feb 11, 2025

Ownership transferred to 0xB524735356985D2f267FA010D681f061DfF03715 https://etherscan.io/tx/0xb0a559f21f6c351c74df81b379123afd010a367a22bac6cb1740e08b8fe88eae

@bmzig bmzig merged commit 7863335 into master Feb 11, 2025
4 checks passed
@bmzig bmzig deleted the bz/atomicWethAdapters branch February 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants