-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: use new atomic depositor in adapters #1852
Conversation
Signed-off-by: nicholaspai <npai.nyc@gmail.com>
Signed-off-by: bennett <bennett@umaproject.org>
This reverts commit 13168f9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmzig LGTM. Have you tested each of these deposit routes?
One additional thought - it'd be nice with a script to ease the process of adding new chains. |
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
…tomicWethAdapters
Signed-off-by: bennett <bennett@umaproject.org>
Reployed at https://etherscan.io/address/0x64668fbd18b967b46dd22dc8675134d91efedd8d so that we could accommodate custom gas token bridges. It has been configured and tested for the following 12 chains: I can confirm that transfer tracking works as expected for all of these deposits. |
deployments/mainnet/solcInputs/c56727864345439ef19e4d0a5f7bee68.json
Outdated
Show resolved
Hide resolved
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this impact any logs emitted and tracked in the outstanding cross chain transaction checks?
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Ownership transferred to 0xB524735356985D2f267FA010D681f061DfF03715 https://etherscan.io/tx/0xb0a559f21f6c351c74df81b379123afd010a367a22bac6cb1740e08b8fe88eae |
This updates the adapters to use the new atomic depositor.