improve(relayer): Persistently ignore expired deposits

across-protocol · Feb 24, 2025 · ab8013d · ab8013d
1 parent 6038b8b
commit ab8013d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/relayer/Relayer.ts b/src/relayer/Relayer.ts
@@ -337,6 +337,12 @@ export class Relayer {
       return ignoreDeposit();
     }
 
+    // It would be preferable to use host time since it's more reliably up-to-date, but this creates issues in test.
+    const currentTime = spokePoolClients[destinationChainId].getCurrentTime();
+    if (deposit.fillDeadline <= currentTime) {
+      return ignoreDeposit();
+    }
+
     const { minConfirmations } = minDepositConfirmations[originChainId].find(({ usdThreshold }) =>
       usdThreshold.gte(fillAmountUsd)
     ) ?? { minConfirmations: 100_000 };
@@ -367,12 +373,6 @@ export class Relayer {
       return false;
     }
 
-    // It would be preferable to use host time since it's more reliably up-to-date, but this creates issues in test.
-    const currentTime = spokePoolClients[destinationChainId].getCurrentTime();
-    if (deposit.fillDeadline <= currentTime) {
-      return false;
-    }
-
     if (this.fillIsExclusive(deposit) && getAddress(deposit.exclusiveRelayer) !== this.relayerAddress) {
       return false;
     }