fix(indexer): allow clean exit by stopping worker #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daywiss
requested review from
amateima and
melisaguevara
and removed request for
amateima
daywiss
requested review from
amateima,
james-a-morris and
melisaguevara
and removed request for
melisaguevara
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/acx-3067-indexer-does-not-exit-cleanly
branch
from
de6f408 to
9a4d823
Compare
melisaguevara
approved these changes
Oct 30, 2024
james-a-morris
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Process seemed to continue after cancelling it
Changes
This was due to worker not being stopped, so now we stop it on ctrl-c, which seems to allow app to exit cleanly