fix(bundles): fix range start block and bundle id when assigning events #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOC which cases would the ids not match? These are foreign keys to incremental ids |
| @@ -18,6 +20,9 @@ export class RootBundleCanceled { | |||
| @Column() | |||
| requestTime: Date; | |||
|
|
|||
| @OneToOne(() => Bundle, (bundle) => bundle.cancelation) | |||
There was a problem hiding this comment.
We would need this to be nullable. I thought we didn't want to change these raw event entities?
Comment on lines
-53
to
+56
| "drb.id", | ||
| "drb.blockNumber", | ||
| "drb.logIndex", | ||
| "drb.transactionIndex", | ||
| "crb.id", | ||
| "crb.blockNumber", | ||
| "crb.logIndex", | ||
| "crb.transactionIndex", |
There was a problem hiding this comment.
Fair call but is out of scope
james-a-morris
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues related to bundles: